-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lib): add additive behavior #82
Conversation
Hey there! Sorry for my late response. I have now looked at your PR and it looks good so far. My question is, how is the "additive" mode supposed to work with For At the end of the day, I think additive should work with |
projects/ngx-drag-to-select/src/lib/select-container.component.ts
Outdated
Show resolved
Hide resolved
@d3lm, ok, no problem. I didn't look at the code again to answer your first comment. I'll try to do that in the next week or so. |
Thanks! |
Alright, #89 was merged. Do you mind updating this PR and rebasing it on top of latest master? Make sure all tests work as expected. Then I ll take another look and review your PR to get this in. |
@d3lm sure, no problem. |
@d3lm, just rebased this branch and started thinking about
Regarding impossible combinations:
Let me know what do you think. |
@vascocc Thanks! I do agree with what you said, tho the branch still has conflicts and cannot be rebased on latest master. Mind checking that out and resolving the issues? |
Also, your changes include changes from previous commits which is a bit strange. It's hard to review the PR. That should normally not be the case 🤔 |
I was using another computer with different tools for managing Git, maybe I messed up the rebase. I'll take a look at it. |
@d3lm, I really messed up the rebase. I think this branch it's beyond recovery. If you don't mind I can start again and do a new pull request. |
Yea I think that would be nice if you started with a new PR, cause this one is now pretty messy and has changes from other PRs. But you can of course just take your code and copy it over into a new PR. Appreciate your work on this one! |
This commit adds additive behavior, mimicking the behavior when holding the Shift key. Updated app to be able to select addictive behavior. Updated Cypress tests. Updated documentation.
I just wanted to ask if there is any update on this one, but I must have missed your force push into this PR. I ll take a look at it. |
Hey @vascocc, so I have checked out this PR on my machine but I cannot verify the behavior you have described above:
For me, when
This is also something I cannot verify because items for me never get unselected.
This is not the case for me, as described above. Do you mind elaborating on this? |
I'm working on a new branch. Hope I can finish this weekend. As I mentioned before, I'm going to close this PR and open a new one. Sorry for the delay. I'll check those issues too. |
Got it! Thanks 🙏 |
This commit adds additive behavior, mimicking the behavior when holding the Shift key. Fixed Additive implementation; Updated tests and documentation;
Closing this PR. |
New PR at #94 |
This commit adds additive behavior, mimicking the behavior when holding the Shift key.
Updated app to be able to select addictive behavior.
Updated Cypress tests.
Updated documentation.